Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.x] fix: change condition when unread label is shown in Scrubber #4116

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

DavideIadeluca
Copy link
Contributor

@DavideIadeluca DavideIadeluca commented Nov 18, 2024

Fixes #3838

Changes proposed in this pull request:

  • Only set opacity of Scrubber-unread to 1 if unreadPercent is greater then 0.

Reviewers should focus on:
As discovered in #3838 and verified just now, unreadPercent evaluates to a negative value when composing a new post. This is because this.stream.index returns unexpected values.

Ideally, the issue would be fixed at its root cause, but for backwards compatibility I feel like it's better if the PostStreamState is left untouched and the issue be fixed in the styleUnread function itself

Screenshot

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

Required changes:

  • Related documentation PR: (Remove if irrelevant)

@DavideIadeluca DavideIadeluca marked this pull request as ready for review November 18, 2024 06:34
@DavideIadeluca DavideIadeluca requested a review from a team as a code owner November 18, 2024 06:34
@imorland imorland added this to the 1.8.9 milestone Nov 18, 2024
@imorland imorland added type/bug javascript Pull requests that update Javascript code labels Nov 18, 2024
@imorland imorland merged commit 88abe63 into flarum:1.x Nov 19, 2024
274 checks passed
@imorland imorland deleted the di/fix-0-unread-in-scrubber branch November 19, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
javascript Pull requests that update Javascript code type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants