[1.x] fix: change condition when unread
label is shown in Scrubber
#4116
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3838
Changes proposed in this pull request:
Scrubber-unread
to1
ifunreadPercent
is greater then0
.Reviewers should focus on:
As discovered in #3838 and verified just now,
unreadPercent
evaluates to a negative value when composing a new post. This is becausethis.stream.index
returns unexpected values.Ideally, the issue would be fixed at its root cause, but for backwards compatibility I feel like it's better if the
PostStreamState
is left untouched and the issue be fixed in thestyleUnread
function itselfScreenshot
Necessity
Confirmed
composer test
).Required changes: